Skip to content

Move the extension directory API to /v2 - #298

Closed
admdly wants to merge 2 commits into
mainfrom
codex/v2-api-namespace
Closed

admdly wants to merge 2 commits into
mainfrom
codex/v2-api-namespace

Conversation

@admdly

@admdly admdly commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Withdrawn: retain the existing /extensions/v2/extensions/{id} layout. The service prefix and extension collection represent different scopes; keeping both avoids reserving extension IDs for service routes and changing all callers.

No API routing change is needed. Badges from merged #297 retain their original URLs. FOSSBilling/extensions#408 and FOSSBilling/extensions-extra#2 use those URLs; the companion publisher and installer namespace PRs are also withdrawn.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-05T18:04:29.660174Z 2fb69d4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found and verified against the latest diff

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/app/index.ts">

<violation number="1" location="src/app/index.ts:28">
P1: This route change makes the existing FOSSBilling client call a dead URL: FOSSBilling/FOSSBilling/src/core/Remote/ExtensionManager.php:28 still builds detail and list requests under `/extensions/v2/`, which this deployment intentionally makes return 404. Update and deploy the installer/client in lockstep before removing the old base, or retain a temporary alias.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread src/app/index.ts Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 24 files

Requires human review: Moves the extension v2 API base from /extensions/v2 to /v2 and removes the old path, changing a public contract with coordinated external deployment required.

Turn on auto-fix | Re-trigger cubic

@admdly admdly self-assigned this Nov 5, 2026
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
api 40f537d Nov 05 2026, 06:04 PM

@admdly admdly closed this Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant