Skip to content

fix(weather): handle expired widget forecasts #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YinCheng0106 wants to merge 1 commit into
base: main
Choose a base branch
from
+944 −51
Open

fix(weather): handle expired widget forecasts #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ios/DPIPWidgets/DPIPWidgetProviderSupport.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ struct DPIPWidgetTimelinePlanner: Sendable {
deviceNow: deviceNow,
staleAfter: staleAfter
)
let reloadDate = deviceNow.addingTimeInterval(refreshInterval)
var reloadDate = deviceNow.addingTimeInterval(refreshInterval)
let forecast: ForecastWidgetSnapshot?
if ForecastWidgetFamilyPolicy.supportsForecast(family),
let snapshot,
Expand All @@ -235,7 +235,14 @@ struct DPIPWidgetTimelinePlanner: Sendable {
calibratedTimeOffsetMilliseconds:
snapshot.calibratedTimeOffsetMilliseconds
)
if expiry > deviceNow, expiry < reloadDate,
reloadDate = ForecastWidgetExpiry.requestedReloadDate(
now: deviceNow,
normalReloadDate: reloadDate,
expiry: expiry
)
// Reload eligibility is not an execution guarantee. Supply the
// expiry state even when it falls after the requested reload.
if expiry > deviceNow,
!states.contains(where: { $0.date == expiry }) {
states.append(CurrentWeatherWidgetTimeline.state(
snapshot: snapshot,
Expand Down
Loading
Loading