Guard Folia creature cause expansion by region ownership - #2312
Open
baichuan335 wants to merge 1 commit into
Open
baichuan335 wants to merge 1 commit into
baichuan335 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2311.
On Folia,
Cause.Buildercan expand a projectile shooter that belongs to another Region. For creature shooters, that expansion reads mutable AI state throughCreature#getTarget()(and for creepersCreeper#getTarget()/getIgniter()), which violates Folia ownership rules during vehicle damage handling.This change keeps the projectile, shooter, and other cause objects in the cause chain, but skips only the mutable creature AI-state expansion when the creature is not owned by the current Region. Non-Folia behavior is unchanged, and locally owned Folia creatures retain the existing expansion behavior.
Verification
./gradlew.bat build -s --max-workers=11.21.11-14, commit529aabc7.4.3+7515-78babeb7.0.17with this fix applied25.0.4.1projectile-owned-by-current=trueshooter-owned-by-current=falseVehicleDamageEvent returned; cancelled=truewith globalvehicle-destroy: denyThread failed main thread check,CraftMob.getTarget()cross-Region exception, or other exception/error outputThe same runtime behavior was also compared against the newer Folia 26.2 environment separately; that version changes projectile shooter ownership behavior, so it was not used as evidence for the original issue.