tests: fix grpc port flake in test_unix_socket_path_length - #9579
Merged
cdecker merged 1 commit intoSep 28, 2026
Merged
Conversation
The test builds LightningNode directly instead of via
node_factory.get_node(), so it never allocated a reserved grpc port.
LightningNode then fell back to the hardcoded default 9736, which is not
in the port reservation pool, and cln-grpc failed with:
plugin-cln-grpc: Error running grpc interface: Err(serving requests
Caused by:
1: Address already in use (os error 98)
Pass a reserved port for grpc_port too.
Changelog-None
cdecker
approved these changes
Sep 28, 2026
cdecker
enabled auto-merge (rebase)
September 28, 2026 13:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test builds LightningNode directly instead of via node_factory.get_node(), so it never allocated a reserved grpc port. LightningNode then fell back to the hardcoded default 9736, which is not in the port reservation pool, and cln-grpc failed with:
Pass a reserved port for grpc_port too.
Changelog-None
Fixes: #9565