Repository navigation
SSE API cleanup - #513
Draft
willmmiles wants to merge 4 commits into
Draft
SSE API cleanup#513willmmiles wants to merge 4 commits into
willmmiles wants to merge 4 commits into
Conversation
A client can be disconnected with its report still queued. Skipping it left the last handle to drop here, so its destructor reported the disconnect. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Draft because I haven't thoroughly reviewed this yet and I probably won't get to it until tomorrow; figured I'd post the WIP up anyways. |
Member
The changeset looks good to me! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up the server side event API to make internal portions private; this strengthens some invariants allowing some additional checks to be dropped. Includes a simplification of
AsyncEventSource::close()that reduces copying and duplication (though to be fair this is very likely a rarely used call.)