Skip to content

Migrate to with_tcp_core_lock - #132

Merged
mathieucarbou merged 4 commits into
mainfrom
with-tcp-core-lock
Nov 14, 2026
Merged

mathieucarbou merged 4 commits into
mainfrom
with-tcp-core-lock

Conversation

@willmmiles

Copy link
Copy Markdown

Migrate the remaining direct uses of tcpip_api_call to with_tcp_core_lock, and apply a couple of logic fixes to the disconnect notification if the connection is closed while an error event is pending.

willmmiles and others added 4 commits November 14, 2026 00:24
Each operation's LwIP-context work now sits in the function that needs it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mockrtos::preempt_async_task() runs an action, as another task would, at the async
task's next mutex release - in a pump, right after it takes an event off the queue.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
close() can't purge an error event the async task has already dequeued, so both
could claim the notification and report the connection twice.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A close() on another task can report the connection, and its onDisconnect reconnect,
while the async task still holds the reset it had already dequeued.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mathieucarbou
mathieucarbou merged commit b8b804f into main Nov 14, 2026
32 checks passed
@mathieucarbou
mathieucarbou deleted the with-tcp-core-lock branch November 14, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants