Repository navigation
Migrate to with_tcp_core_lock - #132
Merged
Merged
Conversation
Each operation's LwIP-context work now sits in the function that needs it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mockrtos::preempt_async_task() runs an action, as another task would, at the async task's next mutex release - in a pump, right after it takes an event off the queue. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
close() can't purge an error event the async task has already dequeued, so both could claim the notification and report the connection twice. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A close() on another task can report the connection, and its onDisconnect reconnect, while the async task still holds the reset it had already dequeued. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mathieucarbou
approved these changes
Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the remaining direct uses of
tcpip_api_calltowith_tcp_core_lock, and apply a couple of logic fixes to the disconnect notification if the connection is closed while an error event is pending.