Repository navigation
Revert attempt to reduce script output for modules we know shouldn't exist - #30
Merged
Merged
Conversation
ocaisa
commented
Oct 14, 2026
| # If we have an accelerator module let's check which architectures are supported | ||
| if detected_accel_arch: | ||
| base_version_dict["gpu_arch"][arch] = [] | ||
| if detected_accel_arch in ROCM_ARCHITECTURES: |
Member
Author
There was a problem hiding this comment.
This incorrectly had accel_arch previously so was only checking NVIDIA accelerators
Member
Author
|
I have to get this out as we now have bad data in the wild...but we clearly need better CI that checks more things |
Member
Author
|
I'll revisit the effort to reduce the unnecessary checks and take the opportunity to add more checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made an attempt to not check for modulefiles which I know don't exist (for example Granite Rapids in anything other than
2026.06), but I seem to have messed up the condition I used in https://github.com/EESSI/api_data/pull/29/files#diff-c03413527863bd66b517e8e5f1938df64308f3baf7ef0365e03fd6efe6cd2e92R148This reverts that change and also fixes a bug for ROCm archs