Conversation
Move element-specific command bindings (CLEAR, LOCATION_IN_VIEW, and IS_ELEMENT_DISPLAYED) from WebDriver to WebElement class. Commands are registered on the parent driver's command_executor when a WebElement is initialized.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Move element-specific command bindings (CLEAR, LOCATION_IN_VIEW, and IS_ELEMENT_DISPLAYED) from WebDriver to WebElement class. Commands are registered on the parent driver's command_executor when a WebElement is initialized.
Move element-specific command bindings (CLEAR, LOCATION_IN_VIEW, and IS_ELEMENT_DISPLAYED) from WebDriver to WebElement class. Commands are registered on the parent driver's command_executor when a WebElement is initialized.
Move element-specific command bindings (CLEAR, LOCATION_IN_VIEW, and IS_ELEMENT_DISPLAYED) from WebDriver to WebElement class. Commands are registered on the parent driver's command_executor when a WebElement is initialized.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All reviewed changes are covered and no unresolved issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Moves element-specific command registration from WebDriver to WebElement.
Changes:
- Registers
CLEAR,LOCATION_IN_VIEW, andIS_ELEMENT_DISPLAYEDon elements. - Removes driver-level registrations.
- Adds
is_displayed()coverage.
| File | Changes |
|---|---|
test/unit/webdriver/webelement_test.py |
Tests displayed-element behavior. |
appium/webdriver/webelement.py |
Registers element-specific commands. |
appium/webdriver/webdriver.py |
Removes driver-level registrations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Moves element commands (
CLEAR,LOCATION_IN_VIEW, andIS_ELEMENT_DISPLAYED) fromWebDrivertoWebElementinappium/webdriver/webelement.py.PR created automatically by Jules for task 14986404072696802697 started by @Dor-bl