Skip to content

test: add unit tests for MobileErrorHandler - #18

Closed
Dor-bl wants to merge 4 commits into
masterfrom
test/add-errorhandler-tests-4158641575643765777
Closed

Dor-bl wants to merge 4 commits into
masterfrom
test/add-errorhandler-tests-4158641575643765777

Conversation

@Dor-bl

@Dor-bl Dor-bl commented Sep 13, 2026

Copy link
Copy Markdown
Owner

Added unit test suite test/unit/webdriver/errorhandler_test.py covering all early return paths, error mapping logic, custom Appium exceptions, and stacktrace formatting edge cases in appium/webdriver/errorhandler.py.


PR created automatically by Jules for task 4158641575643765777 started by @Dor-bl

…_stacktrace

Adds unit tests covering error handling paths and edge cases in
`MobileErrorHandler.check_response` and `format_stacktrace`.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

…_stacktrace

Adds unit tests covering error handling paths and edge cases in
`MobileErrorHandler.check_response` and `format_stacktrace`.
…_stacktrace

Adds unit tests covering error handling paths and edge cases in
`MobileErrorHandler.check_response` and `format_stacktrace`.
…_stacktrace

Adds unit tests covering error handling paths and edge cases in
`MobileErrorHandler.check_response` and `format_stacktrace`.

Dor-bl commented Sep 24, 2026

Copy link
Copy Markdown
Owner Author

Closing: duplicate of #17. Both PRs add a brand-new test/unit/webdriver/errorhandler_test.py covering format_stacktrace and MobileErrorHandler.check_response, so they conflict outright and only one can land. #17 has slightly broader coverage (non-dict frame elements, explicit unmapped-error fallback), so keeping that one open. This PR doesn't add anything beyond it worth mirroring separately upstream.


Generated by Claude Code

@Dor-bl Dor-bl closed this Sep 24, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing: duplicate of #17. Both PRs add a brand-new test/unit/webdriver/errorhandler_test.py covering format_stacktrace and MobileErrorHandler.check_response, so they conflict outright and only one can land. #17 has slightly broader coverage (non-dict frame elements, explicit unmapped-error fallback), so keeping that one open. This PR doesn't add anything beyond it worth mirroring separately upstream.


Generated by Claude Code

Understood. Acknowledging that this work is duplicate/obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant