Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workflows cli submit let's user set workflow parameters AP-1221
Summary
Adds support for passing workflow parameters when submitting workflows via the CLI.
Changes
Added -p/--parameter option to the submit command.
Supports specifying multiple parameters
Parameters are forwarded directly to argo submit using Argo's native parameter override mechanism.
Values are passed through unchanged, allowing:
Strings
Numbers
JSON objects
JSON arrays
Testing
Verified CLI argument parsing for -p/--parameter.
Verified parameters are forwarded to the generated argo submit command.
Existing submit workflow tests pass:
test_submit_manifest
test_submit_helm
multiple_templates
Manually verified submission flow reaches Argo with supplied parameters.
Allows users to override workflow parameters at submission time without modifying the workflow template, matching the capabilities provided by the underlying Argo CLI.