Register DataCollectionGroup and Atlas placeholders using lamella images - #899
Merged
Merged
Conversation
… ImagingSite if not already present, and to link them together
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #899 +/- ##
==========================================
+ Coverage 55.12% 55.21% +0.08%
==========================================
Files 103 103
Lines 11559 11555 -4
Branches 1533 1535 +2
==========================================
+ Hits 6372 6380 +8
+ Misses 4843 4830 -13
- Partials 344 345 +1 🚀 New features to boost your workflow:
|
tieneupin
marked this pull request as ready for review
September 24, 2026 13:34
…andle any exceptions raised
…gistration instead of loading the entry point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to add DataCollectionGroup and Atlas registration logic to the lamella image registration workflow. The workflow will now create a placeholder DataCollectionGroup and Atlas in ISPyB for the lamella image if one hasn't already been created by the atlas workflow. A record of that DataCollectionGroup will also stored in Murfey.
We also established that the current method of try-excepting sections of code to return specific logs has bloated the function, and have removed these
try-exceptblocks and their logs. The Murfey database connection is now handled by the context manager infeedback_callback, so the outertry-finallyblock is also no longer needed.Actual diff is +113/-77, with the rest of the diff being due to the extension and modification of existing tests.