Popup: take the drag and resize area from the view port - #35301
Merged
EugeniyKiyashko merged 1 commit intoSep 23, 2026
Merged
EugeniyKiyashko merged 1 commit into
EugeniyKiyashko merged 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Changes are covered by unit, QUnit, and end-to-end tests with no unresolved review comments.
Review effort: Lite
Findings: None
What changed in this PR
Updates popup drag and resize boundaries to use the configured viewport instead of swatch markup containers.
Changes:
- Adjusts boundary selection precedence.
- Adds unit and QUnit regression coverage.
- Adds end-to-end swatch dragging coverage.
| File | Reviewed changes |
|---|---|
packages/devextreme/testing/tests/DevExpress.ui.widgets/popup.tests.js |
Adds popup drag and resize regression tests. |
packages/devextreme/js/__internal/ui/popup/popup_position_controller.ts |
Selects the appropriate drag and resize boundary. |
packages/devextreme/js/__internal/ui/popup/__tests__/popup_position_controller.test.ts |
Adds boundary-selection tests. |
e2e/testcafe-devextreme/tests/editors/overlays/popup.drag.ts |
Adds swatch-scoped end-to-end drag coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
EugeniyKiyashko
force-pushed
the
fix/popup-drag-area-in-swatch
branch
from
September 22, 2026 20:21
22d747c to
11b43e3
Compare
EugeniyKiyashko
force-pushed
the
fix/popup-drag-area-in-swatch
branch
from
September 22, 2026 20:46
11b43e3 to
d83ea46
Compare
A popup owned by an element inside a swatch could not be dragged at all, and resizing shrank it instead of growing it. The area it may be moved within was read off the markup container, which for such a popup is a bare div the view port carries so the overlay is painted in the colours of the scope it was opened from. That div has no box of its own - its only children are the positioned overlay wrappers - so the area was a strip of zero height: drag was refused outright, and resize clamped the height to a negative offset. The area now comes from the container the popup was given, or from the view port, and never from the markup container. Where the markup goes is unchanged.
EugeniyKiyashko
force-pushed
the
fix/popup-drag-area-in-swatch
branch
from
September 22, 2026 21:10
d83ea46 to
6abd1df
Compare
Raushen
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.