Skip to content

chore: bump android-actions/setup-android to v4.0.4 and use Java 17 - #340

Merged
satsukies merged 2 commits into
masterfrom
chore/bump-setup-android-v4
Oct 2, 2026
Merged

satsukies merged 2 commits into
masterfrom
chore/bump-setup-android-v4

Conversation

@satsukies

@satsukies satsukies commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

Summary

The build job has been failing since 2026-09-17 because android-actions/setup-android@v2 requests the deprecated tools SDK package, which is no longer served:

Warning: Failed to find package 'tools'
Error: The process '/usr/local/lib/android/sdk/cmdline-tools/7.0/bin/sdkmanager' failed with exit code 1

See android-actions/setup-android#537. This was fixed upstream in v4.0.2 (the default packages is now platform-tools only).

Changes

  • Bump android-actions/setup-android from v2 to v4.0.4, pinned by commit SHA like the other actions in this repo.
    • v4 still exports ANDROID_SDK_ROOT and adds sdkmanager to PATH, so the subsequent steps of setup-buildtools work unchanged.
    • v4 runs on Node 24, which also removes the Node 20 deprecation warning.
  • Use Java 17 instead of 11 in the build job matrix.
    • v4 installs cmdline-tools 22.0, whose sdkmanager requires JDK 17 or later (This tool requires JDK 17 or later. Your version was detected as 11.0.32.1.).
    • Java 11 was originally chosen in chore(deps): use Java11 in GitHub actions #101 only to satisfy the sdkmanager requirement at that time, so this follows the same reasoning.

Follow-ups

Unblocks the Dependabot PRs whose build job is currently failing (e.g. #339).

🤖 Generated with Claude Code

Copilot AI balanced review requested due to automatic review settings October 2, 2026 01:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused dependency update resolves the documented SDK package failure without requiring downstream workflow changes.

Review effort: Balanced
Findings: None

What changed in this PR

Updates Android SDK setup to restore the failing build workflow.

Changes:

  • Upgrades android-actions/setup-android from v2 to v4.0.4.
  • Pins the action to a commit SHA.
File Description
.github/​actions/​setup-buildtools/​action.yml Updates the Android setup action used before installing build tools.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copilot AI balanced review requested due to automatic review settings October 2, 2026 02:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The undocumented Java 17 migration exceeds the stated action-upgrade scope.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)

Comment thread .github/workflows/build-and-test.yml
@satsukies satsukies changed the title chore: bump android-actions/setup-android from v2 to v4.0.4 chore: bump android-actions/setup-android to v4.0.4 and use Java 17 Oct 2, 2026
@satsukies satsukies self-assigned this Oct 2, 2026

@enomoto-kazuya enomoto-kazuya left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satsukies

Copy link
Copy Markdown
Member Author

thanks!

@satsukies
satsukies merged commit 84669ee into master Oct 2, 2026
5 checks passed
@satsukies
satsukies deleted the chore/bump-setup-android-v4 branch October 2, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants