Repository navigation
chore: use ubuntu-24.04 runner image and install ImageMagick - #209
Merged
Merged
Conversation
satsukies
force-pushed
the
chore/use-ubuntu-2404-image
branch
from
October 2, 2026 03:02
ee4c5be to
657ffe3
Compare
satsukies
changed the title
ubuntu-2404 image
satsukies
marked this pull request as ready for review
October 2, 2026 06:01
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The runner migration is complete and the required ImageMagick dependency is installed correctly.
Review effort: Balanced
Findings: None
What changed in this PR
Updates GitHub Actions to Ubuntu 24.04 and preserves image-comparison specs by explicitly installing ImageMagick.
Changes:
- Pins all workflow jobs to
ubuntu-24.04. - Installs ImageMagick before running specs.
| File | Description |
|---|---|
.github/workflows/build-and-test.yml |
Updates runners and installs ImageMagick. |
.github/workflows/automerge.yml |
Updates the Dependabot runner. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
satsukies
requested review from
enomoto-kazuya and
henteko
and removed request for
enomoto-kazuya
October 2, 2026 06:07
Member
Author
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ubuntu-22.04toubuntu-24.04.buildjob before running specs.Why ImageMagick is needed
The icon comparison specs in
spec/android_apk_spec.rb(#available_png_iconand#app_iconscompatibility) useMiniMagick::Tool::Compare, which shells out to ImageMagick'scompare. Theubuntu-22.04runner image ships ImageMagick, butubuntu-24.04does not, so 72 specs failed with:mini_magickis a development-only dependency, so the gem itself is unaffected.Notes
ubuntu-24.04instead ofubuntu-latestto avoid unexpected image changes.ubuntu-26.04is not used yet:ruby/setup-rubyhas no prebuilt Ruby (including 2.7.8) for it. Moving there will need a Ruby version bump first, which will be handled in a separate PR.🤖 Generated with Claude Code