Repository navigation
ECHO-1032 fix: an upload never fails because of its file's name - #1346
Merged
Merged
Conversation
A long file name pushed the stored chunk path past varchar(255) and the
upload failed after the file arrived ("Je bestand is binnengekomen, maar
we konden het niet opslaan").
- conversation_chunk.path and conversation.participant_name are text
(0042, no rows rewritten)
- an upload's key keeps at most 80 safe characters of the name plus its
extension, so names with "..", spaces or decomposed accents work too
- initiate clips the participant name and user agent to 255 characters
Contributor
|
Now on staging, deployed 2026-10-26 13:52 UTC. |
Contributor
|
Released in v3.5.2. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A long file name pushed the stored chunk path past varchar(255) and the upload failed after the file arrived ("Je bestand is binnengekomen, maar we konden het niet opslaan").