Repository navigation
Add missing keyword icons from gameclient handoff - #355
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
7d2c8450480a6c3d78a8c89f1a3a7fd63a330692,docs/keyword-icon-handoff/.Validation
node scripts/test-keyword-icons.cjs: all 79 effect/ability paths exist; all 19 imported SVGs match source hashes and contain no embedded images, links or executable content.node scripts/test-cardobject-compat.cjs: passes.npm run build(including TypeScript check): passes in the asynchronous retry. Initial synchronous attempts exceeded the command time limit; the completed retry exited with status 0. Existing dependency/chunk-size warnings remain.Deployment
Keep configuration PR #354 separate. Before deploying this branch to lxgr, merge #354 and synchronize this branch with master so the build retains the correct HTTPS endpoints and cardtestnet-14. No deployment label is applied here yet.
No Cardobject class/schema changes, chain changes, CardchainCS changes, gameclient edits/execution, production endpoint changes or local review pages included.