Skip to content

Add missing keyword icons from gameclient handoff - #355

Merged
patrickwieth merged 1 commit into
masterfrom
fix/keyword-icon-assets
Nov 1, 2026
Merged

patrickwieth merged 1 commit into
masterfrom
fix/keyword-icon-assets

Conversation

@patrickwieth

@patrickwieth patrickwieth commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Import the 19 missing keyword SVGs from gameclient commit 7d2c8450480a6c3d78a8c89f1a3a7fd63a330692, docs/keyword-icon-handoff/.
  • Preserve existing Ambush, Ravage and Requiem icons; do not silently replace their artwork.
  • Keep imported bytes unchanged, using lowercase filenames expected by the existing AbilityModal.
  • Document source/provenance and SHA-256 hashes. Source artwork is supplied as drafts; Salvage reuses existing project geometry, without a new independent license-clearance claim.
  • Add a CI regression check covering every effect/ability icon path in the bundled schema.

Validation

  • Source handoff SHA256SUMS verified.
  • node scripts/test-keyword-icons.cjs: all 79 effect/ability paths exist; all 19 imported SVGs match source hashes and contain no embedded images, links or executable content.
  • node scripts/test-cardobject-compat.cjs: passes.
  • Chromium test mounts the actual AbilityModal with the schema's effect/ability options, loads all 19 new icons and verifies non-empty rendered pixels for each. Screenshot retained locally.
  • npm run build (including TypeScript check): passes in the asynchronous retry. Initial synchronous attempts exceeded the command time limit; the completed retry exited with status 0. Existing dependency/chunk-size warnings remain.

Deployment

Keep configuration PR #354 separate. Before deploying this branch to lxgr, merge #354 and synchronize this branch with master so the build retains the correct HTTPS endpoints and cardtestnet-14. No deployment label is applied here yet.

No Cardobject class/schema changes, chain changes, CardchainCS changes, gameclient edits/execution, production endpoint changes or local review pages included.

@patrickwieth
patrickwieth merged commit 37d7c10 into master Nov 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant