Skip to content

Shorten approved keyword descriptions and preserve agreed class grants - #108

Open
patrickwieth wants to merge 2 commits into
masterfrom
fix/concise-keyword-descriptions
Open

patrickwieth wants to merge 2 commits into
masterfrom
fix/concise-keyword-descriptions

Conversation

@patrickwieth

@patrickwieth patrickwieth commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Summary

Apply the 20 agreed player-facing descriptions: Toxic Growth, Sacrifice, Ravage, Miraculous Healing, Harden, Grow, Cleanse, Bloodlust, Ascension, Ambush, Fight, OnDiscard, Requiem, Criticality, OnDestruction, Rally, Reprogram, Corpse Explosion, Autopsy and Salvage.

The shortened wording does not alter target enums, parameter shapes, numeric limits, interaction text or execution semantics. In particular, X in the Corpse Explosion/Salvage descriptions is the explicitly approved simplified wording, not a change to their Amount parameters.

This branch also preserves and publishes the previously approved local commit c0026de: Body Count is allowed in all four classes, Autopsy in Technology/Mysticism. The existing nested-class restriction test uses Rally instead of now-unrestricted Body Count.

Validation

  • go test ./keywords -run '^TestApprovedFoundationClasses$' -count=1
  • go test . -run 'Test(KeywordedSchema|CardSchema)$' -count=1
  • go test ./...
  • All pass. Schemas generated only by the existing Go generator tests.
  • Compared with c0026de, keywordedSchema.json has exactly 20 description changes; cardSchema.json is unchanged.
  • Existing Grow validation test retained, with an additional description assertion.

Frontend PR #356 synchronizes only the description metadata while retaining its deployed grammar/class permissions. The additional class grants are not silently enabled in the frontend before a matching chain deployment.

No chain deployment, CardchainCS or gameclient changes. The newer VM work and Windows ancestor a6fcfdb remain preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant