feat(compat): add Azure inventory payload core by nina9753 · Pull Request #175 · DataDog/serverless-components

nina9753 · 2026-09-29T13:44:59Z

Summary

add the reusable serverless compatibility inventory crate and payload builder
collect canonical Azure Functions identity, slot, runtime, and subscription metadata
keep scheduling and transport out of this foundational slice

Stack

feat(compat): add Azure inventory payload core #175 — Azure identity and core payload (this PR)
feat(compat): add GCP inventory collection #176 — GCP inventory collection, based on this PR
feat(compat): add serverless-compat inventory reporter (SVLS-9604) #161 — reporter, transport, and compat integration

#176 targets this PR branch. #161 is based on #176 and remains the top, end-to-end-testable PR, preserving its original URL, comments, and review history. Release workflow/version embedding and reporter enablement are delivered in #161.

Testing

cargo test --package datadog-serverless-compat-inventory --locked --offline
cargo clippy --package datadog-serverless-compat-inventory --all-targets --locked --offline -- -D warnings
rustfmt --edition 2024 --check on all new Rust sources
git diff --check

chatgpt-codex-connector · 2026-09-29T13:45:18Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-02T02:36:37.128342Z	`d0286aa`	New commits
🔒 Security Review	✅ Completed 2026-11-02T02:36:25.888055Z	`d0286aa`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot

Copilot review overview

🟡 Changes recommended

Unsafe test environment mutation, missing override coverage, and the unrelated TLS downgrade should be addressed.

Review effort: Balanced
Findings: 1 · 1

Open (2)

Unsafe environment access is not synchronized across tests · New
Add tests for runtime handoff override precedence and fallback · New

What changed in this PR

Adds the foundational Azure Functions inventory payload crate for Serverless Compat.

Changes:

Collects canonical Azure identity, slot, runtime, region, and subscription metadata.
Builds serialized Fleet Automation inventory payloads.
Adds focused Azure and payload tests.

File	Description
`src/platform/mod.rs`	Dispatches platform metadata collection.
`src/platform/azure.rs`	Collects Azure Functions metadata and identity.
`src/payload.rs`	Constructs serialized inventory payloads.
`src/lib.rs`	Exposes the inventory report API.
`Cargo.toml`	Defines the new crate and dependencies.
`Cargo.lock`	Registers the crate and changes `rustls`.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cd00914fa7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

apiarian-datadog

looks pretty good to me, tho i'd defer to folks more familiar with serverless compat for an ultimate review.

duncanpharvey · 2026-10-15T17:08:25Z

+    // These values are inventory-specific enrichments that are not exposed by
+    // the published libdd-common 5.2 API used by this repository.
+    let region = env
+        .get_var("REGION_NAME")
+        .map(|value| value.trim().to_string())
+        .filter(|value| !value.is_empty());
+    let deployment_slot = env
+        .get_var("WEBSITE_SLOT_NAME")
+        .map(|value| value.trim().to_string())
+        .filter(|value| !value.is_empty() && !value.eq_ignore_ascii_case("production"));


I see that the libdatadog changes were merged. Are you able to do a libdatadog release for those changes so they can be applied in this PR?

DataDog/libdatadog#2629

DataDog/libdatadog#2629 is merged on main, but I have not found a published libdd-common release containing it yet. This PR still uses the local region and slot handling. Once the release is available, I can update inventory to consume the shared helpers. Leaving this open until that dependency update lands.

I merged updates to libdatadog crates today in #196. Can you rebase?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d0286aaaee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-11-02T02:36:33Z

+        report_reason,
+        platform,
+        &ProcessEnv,
+        option_env!("DD_SERVERLESS_COMPAT_BINARY_VERSION"),


Embed the binary version in release builds

When artifacts are built by the repository's publish or release workflows, this compile-time variable is never defined: the current build-datadog-serverless-compat.yml accepts only runner, while publish.yml resolves the version only after downloading the binaries. Consequently option_env! is always None for official artifacts and every report omits serverless_compat_binary_version. Fresh evidence against the earlier thread's claim is that neither current workflow sets or forwards the renamed DD_SERVERLESS_COMPAT_BINARY_VERSION; pass the resolved version into the reusable build and export it for each cargo build.

AGENTS.md reference: AGENTS.md:L24-L31

Useful? React with 👍 / 👎.

Copilot AI balanced review requested due to automatic review settings September 29, 2026 13:45

nina9753 requested review from a team as code owners September 29, 2026 13:45

nina9753 requested review from apiarian-datadog and shreyamalpani and removed request for a team September 29, 2026 13:45

Copilot started reviewing on behalf of nina9753 September 29, 2026 13:45

View session

Copilot AI reviewed Sep 29, 2026

View reviewed changes

Comment thread crates/datadog-serverless-compat-inventory/src/platform/azure.rs Resolved

Comment thread crates/datadog-serverless-compat-inventory/src/payload.rs Resolved

chatgpt-codex-connector Bot reviewed Sep 29, 2026

View reviewed changes

Comment thread crates/datadog-serverless-compat-inventory/src/payload.rs Resolved

This was referenced Sep 29, 2026

feat(compat): add GCP inventory collection #176

Open

feat(compat): add serverless-compat inventory reporter (SVLS-9604) #161

Open

apiarian-datadog reviewed Oct 1, 2026

View reviewed changes

duncanpharvey reviewed Oct 2, 2026

View reviewed changes

shreyamalpani approved these changes Oct 5, 2026

View reviewed changes

nina9753 added this pull request to stack #177 October 5, 2026 20:05

nina9753 requested a review from duncanpharvey October 5, 2026 20:52

duncanpharvey reviewed Oct 15, 2026

View reviewed changes

nina9753 force-pushed the nina.rei/SVLS-9604/compat-inventory-azure branch from 90f9d1e to 6c46ed0 Compare October 16, 2026 20:05

nina9753 requested a review from duncanpharvey October 30, 2026 16:28

nina9753 added 10 commits November 1, 2026 11:37

feat(compat): add Azure inventory payload core

16bbfe6

fix(compat): address Azure inventory review feedback

564506c

fix(compat): harden Azure inventory release metadata

bbd8446

fix(compat): address remaining Azure inventory feedback

3695bc7

fix(compat): address Azure inventory feedback

b7f03ef

fix(compat): clarify Azure runtime inventory fields

adec93a

fix(inventory): clarify compat runtime package version

8d3437e

fix(inventory): distinguish embedded compat binary version

a08626c

refactor(compat): rename inventory payload crate to metadata

5886a4d

fix(compat): use shared Azure region and slot metadata

d0286aa

nina9753 force-pushed the nina.rei/SVLS-9604/compat-inventory-azure branch from 73de443 to d0286aa Compare November 2, 2026 02:32

chatgpt-codex-connector Bot reviewed Nov 2, 2026

View reviewed changes

Conversation

nina9753 commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Stack

Testing

Uh oh!

chatgpt-codex-connector Bot commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

apiarian-datadog left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

duncanpharvey Oct 15, 2026

Choose a reason for hiding this comment

Uh oh!

nina9753 Oct 16, 2026

Choose a reason for hiding this comment

Uh oh!

duncanpharvey Oct 30, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Nov 2, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nina9753 commented Sep 29, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Sep 29, 2026 •

edited

Loading