Repository navigation
DummyModelResult(strategy="mean") uses the mean of the compared observations - #736
Open
ecomodeller wants to merge 1 commit into
Open
ecomodeller wants to merge 1 commit into
ecomodeller wants to merge 1 commit into
Conversation
Closes #724 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #724.
The mean was taken over the whole observation before matching trimmed it, so the baseline depended on how long an observation file was loaded and its r2 was not 0. The mean is now set after matching, from the observations that are compared, in both the matched data and
raw_mod_data. A long-term mean is passed explicitly asdata=.test_compare_model_vs_dummy_for_trackpinned the old value (rmse 1.2259, with a comment that it differs because of the subset); it now asserts r2 = 0 on the subset.🤖 Generated with Claude Code