Skip to content

Renaming "unforbid" to "claim". - #3339

Closed
Penumbra69 wants to merge 5 commits into
DFHack:developfrom
Penumbra69:rename_unforbid_claim
Closed

Penumbra69 wants to merge 5 commits into
DFHack:developfrom
Penumbra69:rename_unforbid_claim

Conversation

@Penumbra69

@Penumbra69 Penumbra69 commented May 2, 2023

Copy link
Copy Markdown
  • Added an alias "unforbid -> claim" in the init
  • related to dfhack #3183

Penumbra69 added 4 commits May 1, 2023 18:18
 - unforbid.lua -> claim.lua
 - unforbid.rst -> claim.rst
 - update documentation to use claim / claimed
 - Update "forbid.lua" to hint at "claim all"
 - added a note to the changelog.txt
 - Added an alias "unforbid -> claim" in the init
 - Skip anchors (..)
 - Anchor unforbid docs to claim.rst
 - Skip anchors (..)
 - Anchor unforbid docs to claim.rst
@lethosor

lethosor commented May 2, 2023

Copy link
Copy Markdown
Member

Per my ramblings on Discord: I'm wondering if this is the direction we want to go, or if just aliasing claim to unforbid would better serve more users. As it stands, without changes to helpdb, one of the commands (whichever is an alias) will be excluded from certain lists and functionality, and unforbid has been around for longer.

@myk002

myk002 commented May 2, 2023

Copy link
Copy Markdown
Member

I put my thoughts on this subject here: #3342

@myk002

myk002 commented May 4, 2023

Copy link
Copy Markdown
Member

@Penumbra69 do you think you could possibly implement the first two items in #3342 ? That is, link up aliases in helpdb so they have help entries? That will take care of them appearing in the autocomplete list and showing appropriate help text when they're in the active commandline.

@Penumbra69

Copy link
Copy Markdown
Author

@Penumbra69 do you think you could possibly implement the first two items in #3342 ? That is, link up aliases in helpdb so they have help entries? That will take care of them appearing in the autocomplete list and showing appropriate help text when they're in the active commandline.

I'll take a look at this tonight, sure!

@ab9rf

ab9rf commented Sep 22, 2026

Copy link
Copy Markdown
Member

This PR appears abandoned, and in any case I think I would prefer to implement a "first class" alias strategy that would allow leaving unforbid in place, making claim an equally-visible alias, than the approach taken here.

@ab9rf ab9rf closed this Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants