This repository was archived by the owner on Oct 1, 2026. It is now read-only.
Repository navigation
feat(fleet): add RemoveNode to drop a node from the inventory - #141
Merged
Merged
Conversation
An admin call that removes a node from the manager's inventory without contacting it, for a node that is gone. confirm_name must equal the node's current name. Additive: one RPC and two messages. Signed-off-by: Bugs5382 <12115015+Bugs5382@users.noreply.github.com>
Contributor
Author
|
Merging for the v0.1.0 test run: CI green and mergeable at merge time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The Fleet Manager has no way to drop a node from its inventory without contacting it.
DecommissionNoderesets the node and keeps the row, so a node that was destroyed stays listed as down forever; in a lab run the row had to be deleted from the database by hand.Closes #139
FleetService.RemoveNode(RemoveNodeRequest) returns (RemoveNodeResponse): removes the node from the inventory without contacting it.node_idnames the node andconfirm_namemust equal its current name. The comment documents the outcomes: NotFound, InvalidArgument on a name mismatch, FailedPrecondition while something still depends on the node (such as a pending enrollment naming it); admin-gated, audited asnode-removed, audit and name history kept, credentials folder moved aside.Docs: the RPC is documented in the companion PR of the manager change that implements it (CryptOS-PKI/cryptos-manager#155); nothing user-facing changes until then.
Merge order: merge this first; the manager PR for #155 pins this branch's head and re-pins to api main once this merges.
Verification
How this was verified
task ci(buf format, buf lint, generate-and-verify with the pinned plugins, Go tests) passes, andbuf breaking --againstmain reports nothing.