This repository was archived by the owner on Oct 1, 2026. It is now read-only.
Repository navigation
ci: drop the PR edit guard on public workflows - #140
Merged
Merged
Conversation
Use the hub template shape for the build, lint, licence, DCO and golic workflows: no edited trigger, plain job names, no edit-only if: or concurrency suffix. After retargeting a stacked PR onto main, CI starts on the next push or a draft-then-ready toggle; the docs say so. Refs CryptOS-PKI/.github#10 Signed-off-by: Bugs5382 <12115015+Bugs5382@users.noreply.github.com>
Bugs5382
marked this pull request as ready for review
October 1, 2026 13:40
github-actions
Bot
added
the
skip-changelog
Contributor
Author
|
Merging for the v0.1.0 test run: CI green and mergeable at merge time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The build, lint, licence, DCO and golic workflows carried an
edited-event guard so that retargeting a stacked PR ontomainwould start CI. GitHub doesn't render the name of a job itsif:skips, so every title or body edit left a skipped run listed under the raw expression, and the guard saves nothing on GitHub-hosted runners in a public repo.These workflows now use the hub template shape:
editedis gone from thepull_requesttypes, the(edit, not run)name suffix and thechanges.basepart ofif:are removed, and the concurrency group is the plain per-PR group. Themainbranch filter, the draft skip andtimeout-minutesare unchanged. PR Checks and the Label Checker keepedited.After a stacked PR is retargeted onto
main, CI starts on its next push, or when the PR is toggled to draft and back to ready. The README and the CI notes inCLAUDE.mdsay so.Workflows:
action-lint.yaml,ci-generate.yaml,job-dco.yaml,job-golic.yaml,job-license-check-go.yamlDocs:
CLAUDE.md,README.mdRefs CryptOS-PKI/.github#10
Verification
How this was verified
actionlint1.7.12 (the pinned release, checksum verified) is clean, with and without-shellcheck=.yamllint -d relaxedon the changed workflows reports fewer findings than before (the long expression lines are gone) and no new ones.task licenseexits 0.changes.baseoredit, not run.Before merging: add a closing comment summarizing what was actually done in this PR
(not just the checked boxes).