Small fixes from the record audit: HISTORY dedup, make_cat warning, split and stamp-size tests - #931
Merged
Merged
Conversation
make_post_process parsed every HISTORY card, so a repeated card wrote a duplicate EPOCH HDU and counted the exposure twice in N_EPOCH; find_exposures already deduplicates the same cards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ngmix lays the tile VIGNET's neighbour markers over each multi-epoch stamp pixel for pixel, so config_tile_Uc.ini's VIGNET_SIZE, default_noimaflags.param's VIGNET and every PiViVi config's multi-epoch STAMP_SIZE must agree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four small fixes from the decision-record audit.
make_post_processdeduplicates HISTORY exposures, asfind_exposuresalready does. A repeated card no longer writes a duplicate EPOCH HDU or double-counts N_EPOCH.make_catlogs a real warning when fewer than 10% of detections have ngmix rows, then continues with sentinels. The dead error path is gone.Each new test fails under an injected bug. Unit and module tests in the dev container: 805 passed, 1 skipped.
Claude Opus 5.5 on behalf of Cail
🤖 Generated with Claude Code