Repository navigation
Keep edits made while Load latest is reading - #130
Open
charan-rathore wants to merge 1 commit into
Open
charan-rathore wants to merge 1 commit into
charan-rathore wants to merge 1 commit into
Conversation
Load latest replaced the page with the returned remote revision even when the operator typed newer work while the read was pending. Capture the confirmed draft identity before the read, preserve a newer draft when it lands, keep the remote snapshot, and ask the operator to choose Load latest again to replace it. Unchanged confirmed drafts load exactly as before. Signed-off-by: Charan Rathore <180254320+charan-rathore@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Edit a page, receive a conflicting remote revision, click Load latest and accept its replacement confirmation. While that read is pending, anything typed into the still-editable page is newer work that was never part of the confirmation. The old code unconditionally adopted the returned remote revision and discarded that newer work.
Fix
Capture the confirmed draft's identity before the read. When it lands, ignore an unmounted document and preserve any newer draft: the remote snapshot is retained and a notice asks the operator to choose Load latest again if they want the replacement. Confirmed drafts that stayed unchanged load exactly as before. No backend, API, schema or layout change.
Verification
tsc --noEmit, targeted ESLint, Prettier check and the production client Vite + server TypeScript builds pass. Pre-existing warnings only (react-test-renderer deprecation, native-loader extension warning, large chunks).Not run: full-repo ESLint, live-host/browser pixel or narrow-screen keyboard verification; no layout change is claimed. Note for review: this touches the same PageDocument.tsx as the open #114 (history/trash), but not its code paths; #126 (external deletion reconciliation) is a different scope.