Repository navigation
Conversation
wmic is gone on recent Windows 11, and the generated concorekill.bat aborted at that line so nothing got killed. Look up the command line with Get-CimInstance instead and match it with findstr.
Author
|
@pradeeban small fix for #600, concorekill.bat now works without wmic. PTAL when you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #600
The generated
concorekill.batnow checks each PID withGet-CimInstance Win32_Processinstead ofwmic, in both concore.py and concore.java. I also switchedfindtofindstrso it can't pick up GNU find when the script is run from Git Bash.Added a Windows-only test that starts a real process, runs the generated script, and checks that the process is killed and both files are removed. It fails on dev and passes with this change. Full suite and Java tests pass.