Skip to content

concorekill.bat silently does nothing on Windows without wmic #600

Description

@bhuvan-somisetty

The concorekill.bat generated by concore.py and concore.java checks each PID with wmic before killing it. wmic isn't there anymore on recent Windows 11, and when cmd can't find the first command in a pipe it aborts the whole batch file.

So the script exits with code 255 right at the wmic line. Nothing gets killed, nothing is printed, and the cleanup never runs. ./stop looks like it worked but all the nodes are still running.

Repro:

  1. On Windows without wmic (where wmic finds nothing)
  2. Run any node that imports concore
  3. Run the generated concorekill.bat

Expected: the node is killed and concorekill_pids.txt / concorekill.bat are cleaned up.

Actual: no output, the node keeps running, both files stay.

Swapping wmic for tasklist or PowerShell's Get-CimInstance Win32_Process should fix it.

Tested on dev at 0d9597f, Windows 11 25H2, Python 3.12.10

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions