London | 26-ITP-Sep | Anita Amirhaeri | Sprint 2 | Coursework/sprint 2 by anitahy73 · Pull Request #1553 · CodeYourFuture/Module-JavaScript-Fundamentals

anitahy73 · 2026-09-20T21:09:46Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1039

Changelist

Sprint 2 | Coursework/sprint 2

Questions

Added comments to explain variable declaration and assignment.

Updated the initials variable to dynamically generate initials from first, middle, and last names.

Corrected comments to clarify the purpose of line 3.

Added variables to extract directory and extension from filePath.

Updated comments to clarify the purpose of the random number generation and the evaluation order of expressions.

Changed 'const' to 'let' for age variable and reassigned it to 1.

Fix variable declaration order to enable correct logging.

Updated last4Digits assignment to convert cardNumber to a string before slicing.

Updated comments to provide answers to questions about the code.

Added comments to explain the purpose of each line in the program.

Clarified effects and return values of alert and prompt functions.

netlify · 2026-09-20T21:09:51Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`f35bfdc`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6ab290e4ddc67400087ed244
😎 Deploy Preview	https://deploy-preview-1553--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

abdishakoor-dev

Good start. initials and dir both come out right, and your answer to e) in 1-percentage-change.js is clear.

Some things to fix before I can mark it Complete:

2-mandatory-errors/3.js still stops with an error. See my comment on line 2.
2-mandatory-errors/1.js line 4 changes what the program does. See my comment.
2-mandatory-errors/1.js, 2.js, 3.js and 4.js: the code is fixed, but no error is written down. The README asks you to explain each error. See my comment on 2.js.
1-key-exercises/4-random.js: one step is missing from your breakdown.
3-mandatory-interpret/1-percentage-change.js: answers a) and b) need a little more.
3-mandatory-interpret/2-time-format.js: answers c), d) and e) are only half done.
3-mandatory-interpret/3-to-pounds.js: the breakdown stops at line 9. Lines 9 to 18 have no explanation yet.
"My code is consistently formatted" is on the checklist. The tool that does it is called Prettier. It sets spacing and indentation to one agreed style. Then a reviewer sees only the changes you meant to make. Right now nine of your files fail that check.

Prettier comes with the CYF extension pack from onboarding. If you are not sure you have it, open VS Code, go to Extensions, and search for CodeYourFuture Extension Pack: https://marketplace.visualstudio.com/items?itemName=CodeYourFuture.cyf-extension-pack

Then open each file you changed, right click in the editor, and choose Format Document. Pick Prettier if VS Code asks. Save, commit and push. To do this on every save, follow the steps here: https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals/blob/main/practical_guide.md

Add the Needs Review label again once you have pushed and I will take another look.

abdishakoor-dev · 2026-09-21T06:15:10Z

 const cardNumber = 4533787178994213;
-const last4Digits = cardNumber.slice(-4);
-
+const last4Digits = string(cardNumber).slice(-4);


Run node 3.js. It stops with a new error. Look at the capital letters. Is string the same as String?

Fixed. It prints 4213 now.

Your prediction is on line 6. Now add the error name: SyntaxError, TypeError or ReferenceError? Was your prediction right?

abdishakoor-dev · 2026-09-21T06:15:10Z

-const age = 33;
-age = age + 1;
+let age = 33;
+age = 1;


Line 1 says the goal. The age should go up by 1. With this line, what is age after line 4? Is that 34?

Fixed. It prints 34 now. Good.

Now add the error. The prep shows three error names: SyntaxError, TypeError and ReferenceError. Which one was it here? And why did it happen?

abdishakoor-dev · 2026-09-21T06:15:10Z

@@ -1,5 +1,5 @@
 // Currently trying to print the string "I was born in Bolton" but it isn't working...
-// what's the error ?
+// what's the error 


Your fix works. But the question "what's the error?" has no answer yet. Put the original code back for a moment. Run it, and copy the exact message node prints. Then explain in your own words why it happens. Do the same in 1.js, 3.js and 4.js. In 3.js, also say if your prediction was right.

The message is there now. Good. One more thing. Why does this error happen? Write it in your own words.

abdishakoor-dev · 2026-09-21T06:15:10Z

+// In this exercise, you will need to work out what num represents?It gives us a random number between 1-100
 // Try breaking down the expression and using documentation to explain what it means
+ //Math.random gives us a random number between 0-1 and the next parantecec returns 100
+//after that we multiple these two given values between 0-100 and the floor methode rounds down the given value


After Math.floor, the number is from 0 to 99. What does + minimum do next? What is the smallest num can be, and the biggest?

Right, 1 to 100. Good.

abdishakoor-dev · 2026-09-21T06:15:10Z

+//Line 5
+//Number(...)
+//Line 5
+//console.log


Your count of 5 is right. Which line is console.log on?

console.log is not on line 9. Look again.

abdishakoor-dev · 2026-09-21T06:15:10Z


 // b) Run the code and identify the line where the error is coming from - why is this error occurring? How can you fix this problem?
-
+//missing a comma between the two arguments.


The reason is right. The question also asks which line. And what error name did node print?

Good. That is the one.

abdishakoor-dev · 2026-09-21T06:15:10Z

+// b) How many function calls are there?1

 // c) Using documentation, explain what the expression movieLength % 60 represents
+//The % operator is called the remainder operator.


This explains % in general. What does movieLength % 60 mean in this program? It is 24 here. 24 what?

Yes, 24 seconds. Good.

abdishakoor-dev · 2026-09-21T06:15:10Z

 // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Arithmetic_Operators

-// d) Interpret line 4, what does the expression assigned to totalMinutes mean?
+// d) Interpret line 4, what does the expression assigned to totalMinutes mean?This removes the seconds that don't make up a complete minute.


That is the first half. What does dividing by 60 give you after that?

Right, 146 minutes.

abdishakoor-dev · 2026-09-21T06:15:11Z

+// d) Interpret line 4, what does the expression assigned to totalMinutes mean?This removes the seconds that don't make up a complete minute.

-// e) What do you think the variable result represents? Can you think of a better name for this variable?
+// e) What do you think the variable result represents? Can you think of a better name for this variable?creates a formatted representation of the movie's length in hours, minutes, and seconds.


Right. The question also asks for a better name. What would you call it?

abdishakoor-dev · 2026-09-21T06:15:11Z

+//const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0");
+//const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0");This uses padStart() to make sure the string has at least 3 characters.
+//const pounds = paddedPenceNumberString.substring(0, paddedPenceNumberString.length - 2);
+//This line extracts the pounds part.


Line 27 and line 28 repeat the same code. Keep one. Then keep going. What do lines 14 to 16 give for pence? What does padEnd do there? And what does line 18 print?

Your pence steps are right now, and £3.99 is correct.

Lines 27 and 28 still repeat the same code. Delete line 27.

Corrected the type conversion from 'string' to 'String' for proper functionality.

Fixed comment to clarify the error message.

Updated comments to clarify the random number generation process.

Updated comments to clarify error details and variable reassignment.

Updated comments for clarity and added explanations for variable meanings.

Updated comments to clarify the conversion process from pence to pounds.

abdishakoor-dev

Good progress. 3.js runs now, and your time-format answers c) and d) are right.

Still to do before I can mark this Complete:

2-mandatory-errors/1.js, 3.js and 4.js: write down which error each file had, and why. 2.js needs the reason too.
3-mandatory-interpret/1-percentage-change.js answer a): check the line for console.log.
3-mandatory-interpret/3-to-pounds.js: lines 27 and 28 repeat the same code.
Prettier: nine files still fail. Format each file you changed, then push. Format on save stops this from happening: https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals/blob/main/practical_guide.md

See my comment on each line. Add the Needs Review label again once you have pushed.

abdishakoor-dev · 2026-09-22T16:32:17Z

@@ -1,2 +1,2 @@
-const 12HourClockTime = "8:53pm";
-const 24hourClockTime = "20:53";
+const twelveHourClockTime = "8:53pm";


Your fix runs. Now add the error.

The prep shows three error names: SyntaxError, TypeError and ReferenceError. Which one was it here? And why did it happen?

anitahy73 added 14 commits September 20, 2026 19:53

Add comments for count variable and assignment

2300ec7

Added comments to explain variable declaration and assignment.

Generate initials from name variables

77546b4

Updated the initials variable to dynamically generate initials from first, middle, and last names.

Fix comments in 1-count.js for clarity

1e39939

Corrected comments to clarify the purpose of line 3.

Extract directory and extension from filePath

d6958a1

Added variables to extract directory and extension from filePath.

Enhance comments for random number explanation

6c5f201

Updated comments to clarify the purpose of the random number generation and the evaluation order of expressions.

Comment out instructions in 0.js

4b1bd0d

Change age variable to let and reassign value

424ec1c

Changed 'const' to 'let' for age variable and reassigned it to 1.

Correct cityOfBirth declaration for logging

18a1da4

Fix variable declaration order to enable correct logging.

Fix last4Digits assignment to handle cardNumber correctly

418784e

Updated last4Digits assignment to convert cardNumber to a string before slicing.

Fix variable naming for clock time constants

7753eb9

Fix missing comma in replaceAll function call

b3a99c0

Add answers to code interpretation questions

ab458e3

Updated comments to provide answers to questions about the code.

Enhance code readability with detailed comments

78097f1

Added comments to explain the purpose of each line in the program.

Update explanations for alert and prompt functions

e953ec6

Clarified effects and return values of alert and prompt functions.

anitahy73 added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Sep 20, 2026

abdishakoor-dev reviewed Sep 21, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 21, 2026

anitahy73 added 8 commits September 21, 2026 22:21

Fix type conversion for last 4 digits extraction

87532a7

Corrected the type conversion from 'string' to 'String' for proper functionality.

Fix age reassignment to increment by 1

87d18e1

Update comment for clarity on ReferenceError

77da0b4

Fixed comment to clarify the error message.

Clarify comments on random number generation

8a38be1

Updated comments to clarify the random number generation process.

Comment out console.log and add notes for debugging

6d264c2

Clarify error message and variable reassignment comments

2e91aea

Updated comments to clarify error details and variable reassignment.

Refine comments in 2-time-format.js for better understanding

b48ce39

Updated comments for clarity and added explanations for variable meanings.

Improve comments for pence to pounds conversion

f35bfdc

Updated comments to clarify the conversion process from pence to pounds.

anitahy73 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 22, 2026

abdishakoor-dev reviewed Sep 22, 2026

View reviewed changes

abdishakoor-dev removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 22, 2026


		// b) Run the code and identify the line where the error is coming from - why is this error occurring? How can you fix this problem?

		//missing a comma between the two arguments.

Uh oh!

Conversation

anitahy73 commented Sep 20, 2026

Learners, PR Template

Task code

Changelist

Questions

Uh oh!

netlify Bot commented Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

abdishakoor-dev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify Bot commented Sep 20, 2026 •

edited

Loading

abdishakoor-dev left a comment •

edited

Loading