Cape Town | 25-ITP-MAY | Asanda Dunn | Sprint 2 | Data Groups - #1447
Open
asandagwala wants to merge 8 commits into
Open
asandagwala wants to merge 8 commits into
asandagwala wants to merge 8 commits into
Conversation
asandagwala
added
📅 Sprint 2
hackertainment
added
Review in progress
|
The programs are generally good. Just test cases do not having enough coverage currently. Try to think of different scenarios when designing test cases. Keep it up. :-) |
hackertainment
added
Reviewed
asandagwala
changed the title
asandagwala
added
the
Needs Review
asandagwala
changed the title
LonMcGregor
reviewed
Sep 22, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Did you run the tests before submitting this? I still see some tests marked as "todo"
In addition I have one comment about a task.
Almost there!
| }; | ||
|
|
||
| // console.log(`${address[2]}`) | ||
| console.log(`My house number is ${address[0]}`); |
There was a problem hiding this comment.
This tells me the house number is undefined? Is that right?
LonMcGregor
removed
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TASK ID: CYF-1083
Self checklist
This PR contains the work done on Sprint 2 of the Data Groups module