[test] Fix Cloud Tests - #3144
Open
chernser wants to merge 5 commits into
Open
[test] Fix Cloud Tests #3144chernser wants to merge 5 commits into
chernser wants to merge 5 commits into
Conversation
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
TriageCategory: Summary What this impacts
Concerns
Required reviewer action
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5c3947d. Configure here.
| assertEquals(updateCount, expectedUpdateCount); | ||
|
|
||
| try (ResultSet rs = stmt.executeQuery("SELECT count() FROM " + getDatabase() + "." + tableName)) { | ||
| try (ResultSet rs = stmt.executeQuery("SELECT count() FROM clusterAllReplicas('default', " + getDatabase() + "." + tableName + ")")) { |
There was a problem hiding this comment.
Replica reads inflate insert counts
Medium Severity
clusterAllReplicas concatenates the user table from every node, so count() is multiplied by replica count. Cloud default uses SharedMergeTree on multiple replicas, so the exact 100000 checks fail and the async count < 100000 check can fail once the rows are visible on more than one node.
Reviewed by Cursor Bugbot for commit 5c3947d. Configure here.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There are few common failures in tests when run against cloud:
Checklist
Delete items not relevant to your PR: