Fix IPv4 byte order handling - #567
Open
FranciscoMaxwell wants to merge 1 commit into
Open
FranciscoMaxwell wants to merge 1 commit into
FranciscoMaxwell wants to merge 1 commit into
Conversation
FranciscoMaxwell
force-pushed
the
fix-ipv4-byte-order
branch
from
September 25, 2026 14:18
4332b93 to
b04e611
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #521.
Summary
This fixes inconsistent byte-order handling in
ColumnIPv4:Append(std::string)now stores the network-order value returned byinet_ptonwithout applying a second byte swap.Append(in_addr)now storesin_addr::s_addras-is, matching the platform/network-order representation used by socket APIs.At()andoperator[]now return the stored network-order representation directly.Append(uint32_t)and the vector constructor continue to accept host-order integer values.in_addrappends serialize to the same bytes.Testing
cmake -S . -B build -DBUILD_TESTS=ONcmake --build build --target clickhouse-cpp-ut --config Debug --parallel 4.\build\ut\Debug\clickhouse-cpp-ut.exe --gtest_filter="ColumnsCase.ColumnIPv4*"git diff --check