Repository navigation
Conversation
Under C++23 libc++, `std::allocator_traits::allocate_at_least` picks up the inherited `std::allocator::allocate_at_least`, so `basic_string` and `vector` growth bypassed `Aws::Malloc`. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
mstetsyuk
added a commit
to ClickHouse/ClickHouse
that referenced
this pull request
Oct 20, 2026
Resolves the conflicts with master and bumps `contrib/aws` to 5dece85092334809d80c3d1ed3dc093f20d0dc33, which is master's 1.11.907 fork branch plus the `allocate_at_least` patch from ClickHouse/aws-sdk-cpp#43. The forwarding `AWSCredentials` constructors are dropped; call sites convert with `Aws::String` explicitly. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under C++23 libc++,
std::allocator_traits::allocate_at_leastpicks up thestd::allocator::allocate_at_leastinherited byAws::Allocator, sobasic_stringandvectorgrowth bypassAws::Mallocand the custom memory manager installed withUSE_AWS_MEMORY_MANAGEMENT.This adds
Aws::Allocator::allocate_at_leastforwarding toallocate. It is a no-op for ClickHouse master, which builds withUSE_AWS_MEMORY_MANAGEMENToff; it is needed by the ClickHouse change that keeps secrets out of core dumps by installing aMADV_DONTDUMPmemory manager into the SDK.🤖 Generated with Claude Code