Skip to content

Fix STS endpoint for AWS European Sovereign Cloud and honor endpointOverride - #42

Merged
alesapin merged 2 commits into
ClickHouse:ClickHouse/1.11.907from
asya-ch:asya/sts-endpoint-override
Oct 17, 2026
Merged

alesapin merged 2 commits into
ClickHouse:ClickHouse/1.11.907from
asya-ch:asya/sts-endpoint-override

Conversation

@asya-ch

@asya-ch asya-ch commented Oct 16, 2026 •

Copy link
Copy Markdown

Issue #, if available: #110699

Description of changes:

STSCredentialsClient harcodes sts.<region>.amazonaws.com. Only China regions are special-cased. This PR (1) adds special casing for AWS European Sovereign Cloud regions, (2) Uses clientConfiguration.endpointOverride when it is set, and (3) adds GetEndpoint so tests can check the result.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AWS European Sovereign Cloud regions (eusc-*) use the .amazonaws.eu suffix,
so derive it the same way the .cn suffix is derived for China regions. Also
expose GetEndpoint() so the derived endpoint can be checked in tests.
@alesapin alesapin self-assigned this Oct 17, 2026
@alesapin
alesapin merged commit c1d5b5f into ClickHouse:ClickHouse/1.11.907 Oct 17, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants