Repository navigation
fix(api): limit failed password logins per email #3759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Aryainguz
wants to merge
3
commits into
ClickHouse:main
Choose a base branch
from
Aryainguz:aryainguz/login-rate-limit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+188
−1
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| '@hyperdx/api': patch | ||
| '@hyperdx/app': patch | ||
| --- | ||
|
|
||
| fix: limit failed password logins to 10 per email every 15 minutes |
120 changes: 120 additions & 0 deletions
120
packages/api/src/routers/api/__tests__/login.int.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| import { getAgent, getLoggedInAgent, getServer } from '@/fixtures'; | ||
| import User from '@/models/user'; | ||
| import { LOGIN_MAX_FAILED_ATTEMPTS } from '@/routers/api/root'; | ||
|
|
||
| const MOCK_USER = { | ||
| email: 'login-limit@example.com', | ||
| password: 'TacoCat!2#4X', | ||
| }; | ||
|
|
||
| describe('POST /login/password rate limit', () => { | ||
| const server = getServer(); | ||
| let signedInAgent: ReturnType<typeof getAgent>; | ||
|
|
||
| beforeAll(async () => { | ||
| await server.start(); | ||
| ({ agent: signedInAgent } = await getLoggedInAgent(server, MOCK_USER)); | ||
| }); | ||
|
|
||
| afterAll(async () => { | ||
| await server.stop(); | ||
| }); | ||
|
|
||
| const login = (email: string, password: string) => | ||
| getAgent(server) | ||
| .post('/login/password') | ||
| .type('form') | ||
| .send({ email, password }); | ||
|
|
||
| it('does not count successful logins', async () => { | ||
| for (let i = 0; i <= LOGIN_MAX_FAILED_ATTEMPTS; i++) { | ||
| const res = await login(MOCK_USER.email, MOCK_USER.password); | ||
| expect(res.status).toBe(303); | ||
| expect(res.headers.location).not.toContain('err='); | ||
| } | ||
| }); | ||
|
|
||
| it('blocks an email after too many failed attempts, even with the right password', async () => { | ||
| for (let i = 0; i < LOGIN_MAX_FAILED_ATTEMPTS; i++) { | ||
| const res = await login(MOCK_USER.email, 'wrong-password'); | ||
| expect(res.headers.location).toContain('/login?err=authFail'); | ||
| } | ||
|
|
||
| const blocked = await login(MOCK_USER.email, MOCK_USER.password); | ||
| expect(blocked.status).toBe(303); | ||
| expect(blocked.headers.location).toContain('/login?err=tooManyAttempts'); | ||
|
|
||
| // Emails are case-insensitive, so another spelling shares the limit. | ||
| const upper = await login(MOCK_USER.email.toUpperCase(), 'wrong-password'); | ||
| expect(upper.headers.location).toContain('/login?err=tooManyAttempts'); | ||
| }); | ||
|
|
||
| it('keeps a separate limit for each email', async () => { | ||
| const res = await login('someone-else@example.com', 'wrong-password'); | ||
| expect(res.headers.location).toContain('/login?err=authFail'); | ||
| }); | ||
|
|
||
| it('counts failed attempts made from a signed-in session', async () => { | ||
| const email = 'signed-in-target@example.com'; | ||
| for (let i = 0; i < LOGIN_MAX_FAILED_ATTEMPTS; i++) { | ||
| await signedInAgent | ||
| .post('/login/password') | ||
| .type('form') | ||
| .send({ email, password: 'wrong-password' }); | ||
| } | ||
|
|
||
| const res = await login(email, 'wrong-password'); | ||
| expect(res.headers.location).toContain('/login?err=tooManyAttempts'); | ||
| }); | ||
|
|
||
| it('limits an email sent in the query string, as passport accepts it there', async () => { | ||
| const query = { email: 'query-target@example.com', password: 'wrong' }; | ||
| // A new X-Forwarded-For each time, so falling back to req.ip can't limit it. | ||
| const attempt = (i: number) => | ||
| getAgent(server) | ||
| .post('/login/password') | ||
| .set('X-Forwarded-For', `10.0.0.${i}`) | ||
| .query(query); | ||
| for (let i = 0; i < LOGIN_MAX_FAILED_ATTEMPTS; i++) { | ||
| await attempt(i); | ||
| } | ||
|
|
||
| const res = await attempt(LOGIN_MAX_FAILED_ATTEMPTS); | ||
| expect(res.headers.location).toContain('/login?err=tooManyAttempts'); | ||
| }); | ||
|
|
||
| it('does not count server errors, such as the database being down', async () => { | ||
| const email = 'outage@example.com'; | ||
| const findByUsername = jest | ||
| .spyOn(User, 'findByUsername') | ||
| .mockImplementation(() => { | ||
| throw new Error('database unavailable'); | ||
| }); | ||
| try { | ||
| for (let i = 0; i <= LOGIN_MAX_FAILED_ATTEMPTS; i++) { | ||
| const res = await login(email, 'wrong-password'); | ||
| expect(res.headers.location).toContain('/login?err=unknown'); | ||
| } | ||
| } finally { | ||
| findByUsername.mockRestore(); | ||
| } | ||
|
|
||
| const res = await login(email, 'wrong-password'); | ||
| expect(res.headers.location).toContain('/login?err=authFail'); | ||
| }); | ||
|
|
||
| it('answers JSON clients such as the CLI with a 429', async () => { | ||
| const attempt = () => | ||
| getAgent(server) | ||
| .post('/login/password') | ||
| .send({ email: 'json-client@example.com', password: 'wrong-password' }); | ||
| for (let i = 0; i < LOGIN_MAX_FAILED_ATTEMPTS; i++) { | ||
| await attempt(); | ||
| } | ||
|
|
||
| const res = await attempt(); | ||
| expect(res.status).toBe(429); | ||
| expect(res.body.error).toBe('tooManyAttempts'); | ||
| expect(res.body.message).toMatch(/too many failed login attempts/i); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.