Repository navigation
Preserve file targets by refusing unsafe process attachment - #69
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attaching a process after Cheat Engine opens a file can report success while leaving its memory backend unusable. Client now checks for a file target inside the existing selection dispatch and refuses before calling the selection port. The failure is
UnsupportedwithNotStarted; it preserves the file and invalidates stale Client target leases. Callers can select a process in Cheat Engine or restart the host before attaching again.Only a proven file-target preflight gets that mapping. Ordinary attach behavior remains intact, and a file-target result observed after selection still reports an unknown host effect. The implementation uses the existing published CheatEngine.SDK 2.0.0 surface without changing dependency pins or lock files.
Validation: the two new refusal tests fail against the old implementation, then all 65 focused tests pass with the fix. The Release solution build passed with zero warnings/errors; the full Core suite passed all 1,657 tests, and the Abstractions, DI, Fluent, Hosting, LivePlugin.Qualification, Repository and SourceGenerators suites passed. Local child-process packaging checks are blocked by this PC lacking the repository's exact .NET 10.0.401 SDK; CI must pass those checks before merge. No live Cheat Engine session was run for this Client patch.