Repository navigation
Support SDK source references in parent workspaces - #67
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Outcome and linked issue
Allow a parent workspace to build Client and SDK from pinned Git checkouts. MCP can now consume both repositories as submodules without retaining a second SDK copy from NuGet.
Scope and architectural ownership
An optional
CheatEngineSdkSourceRootswitches the three SDK-facing Client projects to the SDK Engine and Hosting projects. A parentCheatEngine.Source.propssupplies the same graph to recursive restore and compilation and can redirect source-mode lock files. Standalone Client builds retain the existing package graph.Source builds embed the actual SDK assembly version and full Git commit, read through PE metadata without loading the assembly. Runtime capability checks require that exact source identity. The plugin profile accepts canonical source project paths and checks the resolved Engine assembly's supported major. Source-mode NuGet packing is refused to prevent publishing packages with unreviewed source dependencies.
Dependencies and containing artifacts
CheatEngine.SDK2.0.0 with the existing supported 2.x range and lock files.06c529f84e47295e3ca7a4e81ca808b9c4686b3a.Validation actually performed
Category=PackageConsumptionCHEATENGINECLIENT9051refusalAPI and compatibility
CheatEngineSdkSourceRoot; they must import SDK/Client consumer build assets explicitly because project references do not import package build assets.Evidence
Local test reports are retained in the MCP workspace under
artifacts/test-results/ai-analysis-20261019/client-source-support-package-mode-4andclient-source-support-package-consumption. The source integration is also checked through built MCP dependency manifests and embedded assembly metadata. Independent Astra review found no actionable issues in the source integration; CI remains pending.Documentation and review checklist
CHANGELOG.mdincludes the consumer-visible change under[Unreleased]..git-blame-ignore-revsis included.