Repository navigation
fix: provide standalone kill in Arc runtime images - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
procpsin both release runtimes so Kubernetes can directly execkill; Bash's builtin does not satisfy that interface.killas the container entrypoint and throughenv, rather than accidentally exercising only the shell builtin./tmp/done.doneand/tmp/prune.done, without pre-creating completion files in the image.No Rust, Cargo, node entrypoint, UID/GID, or public RPC execution changes.
Validation
bash -n .github/scripts/test-runtime-image.shandgit diff --check: pass.kill -TERM 1to PID 1, all four exit 143.Local runtime-only fixtures reuse existing application binaries; they are not a rebuild of this commit. Initial validation used the official Debian source after the Waterloo security mirror returned an index size/hash mismatch. The follow-up source fix was then tested with the exact repository source configuration: runtime-base build passed, and UID999 directly executed
/usr/bin/kill -l TERMsuccessfully. Full commit-bound amd64/arm64 images remain subject to CI.Initial CI (35305673132): both arm64 component builds and runtime checks passed; both amd64 builds failed in the existing chef
apt-get updatestep with the same Waterloo index mismatch (339172 bytes received versus 339152 declared). Commitee213fbfremoves that security URI; replacement CI 35307110479 is running/queued, so final candidate publication is not yet verified.Deployment dependency
This image change alone does not repair backup orchestration. SRE must update both maintenance marker writers/readers, wait for EL and CL to stop, and mount the seed data volume in its initContainer. The current deployment files are directly applied resources rather than Arc files tracked in the manifest repository; scoped patches and failure-path tests are retained locally for SRE review. No production changes, release, or merge performed here.
Current user scope is images only. The prepared deployment changes are paused and are not part of this PR.