Repository navigation
#47: close out the cutover; D5 restated: Processor owns the pin; goldens from co-core directly - #49
Merged
Merged
Conversation
…r's v1 byte for byte scripts/gen_parity_goldens.py, rewritten in place: imports only the stdlib and co_core.pure.extract (a test walks its AST), and follows Watcher's a5d6f34 path. On co-core 0.19.7 it reproduces all 13 committed goldens byte for byte (trap 1), and that is now a standing test. goldens.json: digests untouched; Watcher's metadata moved, once by hand, into v1_provenance, which every run carries forward. Each run prints what moved, for the bump note. The version check is re-anchored on co_core + LOCAL_GENERATION. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…oldens from co-core Spec: an amendment entry; D5's row restated with its history; section 5's bump rule; section 6 steps 4 and 5 marked done (watcher#326's gate and soak verdicts, watcher#350); section 7's golden source. AGENTS.md lines 21 and 55 and DEPLOYMENT.md's bump procedure follow, with the never-regenerate-to-pass rule kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er rerun their writer Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t is generator == committed goldens Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ispatch, not co-core's Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s written At a bump such as #29's (cannobserv#523 refuses xpath/regex/jsonpath), the traceback named only the extractor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The golden-source sub-bullet was spliced in mid-paragraph, leaving the parent's Include: sentence trailing it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 10, 2026
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes out the cutover and restates D5 now that watcher#350 has deleted Watcher's extraction. These are the operator decisions of 2026-10-10, from #47's hand-off.
Trap 1: the new generator equals the old oracle
scripts/gen_parity_goldens.pyis rewritten in place, so its path is unchanged andtests/test_drift.pyneeds no edit. It drives co-core's pure extract API directly and follows the path Watcher took ata5d6f34:extractor_for_essence;{**extraction_config_from_spec, **extraction_overrides_for_essence};canonical_text, and its fingerprint is taken even when the text is empty;spec_fingerprintthat raises becomesNone.On co-core 0.19.7 it reproduces all 13 committed goldens byte for byte.
test_reproduces_every_committed_goldenwas green beforegoldens.jsonchanged at all, and it stays as a standing test.Tests and fixtures
co_core.pure.extract.*, nothing fromprocessor.goldens.jsonis nowco_core,generated_byandgoldens. Watcher'sgenerated_by,watcher_commit a5d6f34…,watcher_processor_version 0.19.7+1andco_coremoved intov1_provenance. That move was a one-time hand edit, and no digest was touched. Every regeneration carriesv1_provenanceforward and refuses to run without it.test_extract.py: the version check now assertsPROCESSOR_VERSION == f"{GOLDENS['co_core']}+{LOCAL_GENERATION}". The docstring now names the new golden source.TDD evidence (CR 6). The red step wasn't committed separately;
b1e6369carries the test and the generator together. The reds seen in-session: the new test module failed to collect (ModuleNotFoundError: No module named 'src', the old generator), and after the metadata moved,test_processor_version_matches_watchersraisedKeyError: 'watcher_processor_version'. CR 4's red is in its own run: a bareValueErrorthat didn't name the case.Docs
processor_versionmoves, and coordinates only on a contract change;docs/plans/2026-10-10-47-post-cutover-d5.md.Not changed
src/. No deploy is needed: the drift check sees nothing that runs.real/, Real-input parity corpus from Watcher's export; record watcher#325's answers in the spec #16).Verification
uv run pytest: 597 passed, 6 skipped (after the CR round). The skips are the usual unreadable-credential denial cases.ruff checkandruff format --checkare clean.Remaining for #47 (off-repo)
Refs #47, #1, #29, #37, epic #24, CannObserv/watcher#326, CannObserv/watcher#350.
🤖 Generated with Claude Code