Repository navigation
#43 CR: the mirror's cache miss, docker:// steps, one parse - #46
Merged
Merged
Conversation
…lback mirror.gcr.io serves only cached tags (redis:2.6.17 and busybox:1.21-ubuntu 404 there today), and Redis 7.0 is past EOL, so 7.0.15 can leave the cache. The comment says what that failure looks like and what replaces the mirror. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A step with `uses: docker://<image>` pulls a container like a service does, and with no registry that is an anonymous Docker Hub pull: _images() now finds those too, and takes the workflows directory so a synthetic workflow can prove it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
parametrize's values and ids each called _images(), so collection parsed every workflow twice; one module-level IMAGES feeds both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 10, 2026
Redis 7.0 is upstream EOL (2024-07-29), and broker#85 now owns the choice of the broker's next Redis. ci.yml, BROKER_REDIS and AGENTS.md's CI row say so, since all three move with the broker. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The check rejects any image off mirror.gcr.io, but its message always said "from Docker Hub anonymously", false for a ghcr.io image. It now states the rule, then why an unqualified or docker.io image is the case it guards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Open
17 of 20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #43. Review fixes for #44 (
f36cebc), already merged.ci.yml: the comment names the mirror's failure mode and the fallback.mirror.gcr.ioserves only tags it has cached (redis:2.6.17andbusybox:1.21-ubuntu404 there today), and Redis 7.0 is past EOL. "manifest unknown" at Initialize containers means 7.0.15 dropped out of the cache, not a broken commit. The fallback is Ubuntu 24.04's aptredis-server7.0.15, per #43's hand-off.tests/test_ci.py: the image check also covers step-leveluses: docker://<image>, which is also an anonymous Hub pull. A test on a synthetic workflow proves it.tests/test_ci.py: the workflows are parsed once (IMAGES), not once for the parametrize values and again for the ids.ci.yml,BROKER_REDISand AGENTS.md's CI row.ghcr.ioimage.Local gate: 587 passed, 6 skipped; ruff, format,
uv lock --lockedclean. No deploy: nothing here runs in production.🤖 Generated with Claude Code