Repository navigation
Conversation
…rve MEF headers Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…h-IPAC#129) Read every extension into memory inside the `with` block so the existing downstream `hdulist[...]` cells (including the WAVE-TAB spectral WCS, which needs `fobj=hdulist`) keep working after the file is closed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jkrick
requested review from
afaisst and
troyraen
and removed request for
afaisst
October 22, 2026 22:30
5 of 8 tasks
The README was folded into the notebook and deleted in 00c9664, which left the manifest pointing at a missing file and failed the manifest check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CI hit http.client.RemoteDisconnected while reading SPHEREx images; catch it alongside the other transient errors so cutouts skips the image and psf retries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Added update to fix the failing notebook test. CI hit |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for the upcoming DR1 updates. Closes #150, closes #238, closes #275.
Summary
pyvotoastroquery.ipac.irsa.Irsa.query_tapSkyCoordinstead of separatera/decfloatswriteto(..., overwrite=False)so output isn't silently clobberedQuantityinstead of a bare floatVERSION) in the combined MEF'sprimary HDU instead of writing a blank one, and record each cutout's version in
CUTOUT_INFO(the rest of the README was already duplicated there) and remove the README
memory so the downstream cells work after the file is closed (spherex_intro.md part of Make all
fits.open()calls use a context manager #129)http.client.RemoteDisconnectedas a transient read error in spherex_cutouts.md(skip that cutout) and spherex_psf.md (retry), after CI failed on a server disconnect
mid-read
Note on #129
spherex_cutouts.md, spherex_psf.md, and the SDT notebook already use context managers for
every
fits.open()call. spherex_intro.md's barefits.open()call is fixed here too (purelymechanical, does not touch the QR3-stale content next to it, which stays for #374). The two
Euclid notebooks and the Roman notebook also listed in #129 are untouched -- out of scope for
this PR.
Test plan
(
jupytext --to notebook --execute); no errorsVERSIONis present in the output MEF's primary headerexecution needs SExtractor/Firefly/bokeh, not run here)