Repository navigation
terminal-helper: honor $TERMINAL and harden terminal launching - #97
Open
VictorBravo9er wants to merge 1 commit into
Open
VictorBravo9er wants to merge 1 commit into
VictorBravo9er wants to merge 1 commit into
Conversation
- Honor $TERMINAL when set to a supported emulator. - Add --nofork to konsole to prevent detached launcher exit on KDE Plasma. - Add --wait-for-single-instance-window-close for kitty and --no-remote for lxterminal. - Synchronize execution with started/finished handshake in temp directory, eliminating premature script deletion. - Fix kgx parent process signalling. Fixes CachyOS#87, fixes CachyOS#96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR ports the terminal-helper hardening improvements recently investigated and implemented in CachyOS/CachyOS-Welcome#289 to
cachyos-kernel-manager.Key Improvements:
$TERMINAL: Checked first when set to a supported emulator in the terminal map, respecting user configuration before falling back to the default order.--noforkto Konsole. Without a TTY and without--nofork, Konsole detaches to an existing daemon session, causing the caller to exit immediately.started/finishedhandshake in a temporary directory instead of prematurely deleting the command file immediately upon launcher return. This eliminates the race condition wherepkexec/bashfails withNo such file or directory.kitty: Added--wait-for-single-instance-window-closeto prevent client process detachment.lxterminal: Added--no-remote.kgx: Fixed process signalling to avoid targeting arbitrary ancestor processes (such as the user systemd manager).Fixes #87
Fixes #96