BB2-5215 Add new secrets scanning - #191
Merged
Merged
Conversation
Contributor
|
Seeing some results from: server/.bluebutton-config.json when I run betterleaks dir . -v. Should we ignore that file? |
Contributor
Author
|
No, that's actually working as intended! I should have made a note about
that though. Since that file contains config, it if it were to be
committed, we want it to be detected.
The `dir` mode isn't what actually gets run in pre-commit, it's just to
check all the files in the repo to see if there are any problems.
|
Contributor
|
So for this repo, we'll just know that these errors are fine, because that file is not committed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-5215
What Does This PR Do?
Adds new secrets scanning setup to this repo.
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
Validation
betterleaks dir . -vdoes not find any secrets.