Skip to content

Changes to support filtering/sorting for germplasm - #28

Merged
jloux-brapi merged 5 commits into
epic/BI-2862from
feature/BI-2907
Oct 6, 2026
Merged

jloux-brapi merged 5 commits into
epic/BI-2862from
feature/BI-2907

Conversation

@jloux-brapi

@jloux-brapi jloux-brapi commented Sep 24, 2026 •

Copy link
Copy Markdown

Description

Story: BI-2907

  • Additional changes made to support sorting by numbers, especially for additionalInfo fields
  • Bugs fixed when left join fetches were made but filters were required for specific fields
  • Filtering/Sorting suport added via BrAPIGermplasmSearchRequest

Dependencies

bi-api feature/BI-2907

Testing

General DeltraBreed Germplasm regression is good enough

Checklist:

- Additional changes made to support sorting by numbers, especially for additionalInfo fields
- Bugs fixed when left join fetches were made but filters were required for specific fields
Comment thread src/main/java/org/brapi/test/BrAPITestServer/service/SearchQueryBuilder.java Outdated
Comment thread src/main/java/org/brapi/test/BrAPITestServer/service/SearchQueryBuilder.java Outdated

@humsika humsika left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me and working as expected.

@humsika humsika added the on hold Do not merge until this label is removed label Oct 6, 2026
@jloux-brapi
jloux-brapi merged commit e3eeb37 into epic/BI-2862 Oct 6, 2026
@jloux-brapi jloux-brapi removed the on hold Do not merge until this label is removed label Oct 6, 2026
@jloux-brapi
jloux-brapi deleted the feature/BI-2907 branch October 6, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants