Repository navigation
BI-3069: Observation unit search by studyDbId incorrectly filters results using external reference ID. - #565
Merged
Merged
Conversation
jloux-brapi
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-3069
Observation units were not being returned when filtering by
studyDbId.The search correctly found the observation units using the real
studyDbId, but an additional filter compared that ID with the study’s external reference ID. Since these IDs are different, the matching observation units were removed from the response.This change removes the unnecessary external-reference filter and uses the BrAPI
studyDbIdsearch result directly. The existing germplasm filter remains unchanged.Dependencies
bi-web: epic/BI-2862
bi-api: feature/BI-3069
brapi-Java-ProdServer: epic/BI-2862
Testing
General experiment and observation unit regression, with focus on:
Run the full
bi-apitest suite. All tests are expected to pass.Checklist: