BI-2963: ObservationDAO Optimization: Utilize observation/UnitSearch requests to optimize GET calls in DAO

[humsika]

Description

Story: BI-2963

Updated BrAPIObservationDAO to use the BrAPI observation search endpoint instead of retrieving every observation in a program and filtering the results inside the BI API.

Dependencies

bi-web: epic/BI-2862
bi-api: feature/BI-2963
brapi-Java-ProdServer: epic/BI-2862

Testing

The following manual UI testing needs to be verified using one experiment with observations and one experiment without observations:

1. Open an experiment containing observations under Experiments & Observations.

   • Confirm the dataset loaded successfully.
   • Confirm the observation variables and values were displayed correctly.

2. Download the experiment file.

   • Confirm the download completed successfully.
   • Confirm the observation columns and values were unchanged.

3. Perform an append/overwrite import for an existing observation.

   • Confirm the import completed successfully.
   • Confirm the updated observation value appeared in the dataset.

4. Delete a disposable experiment with and without observations through the UI.

   • Confirm the existing soft-delete behavior completed successfully without an error.

Checklist:

• I have performed a self-review of my own code
• I have tested my code and ensured it meets the acceptance criteria of the story
• I have create/modified unit and/or integration tests to cover this change or tests are not applicable
• I have commented my code, particularly in hard-to-understand areas
• I have either updated the source of truth or arranged for update with product owner if needed https://breedinginsight.atlassian.net/wiki/spaces/BI/pages/1559953409/Source+of+Truth

[jloux-brapi]

Passed validation and looks good to me!