Skip to content

[BI-3032] - Prevent .vcf file name duplication - #562

Merged
nickpalladino merged 4 commits into
developfrom
feature/BI-3032
Oct 6, 2026
Merged

nickpalladino merged 4 commits into
developfrom
feature/BI-3032

Conversation

@HMS17

@HMS17 HMS17 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Description

Story: BI-3032 - Prevent .vcf file name duplication

Updated GigwaGenotypeServiceImpl.java:submitGenotypeData to retrieve existing genotype imports and check if the vcf file name matches that of a vcf file already imported and if so, prevent import with an error message.

Dependencies

bi-web: develop

Testing

Try to import a vcf file with the same filename as another vcf already imported, check that import is prevented and error message appears

Other good cases to test:
Valid import with different filename: should import
Import with same filename and incorrect header: filename error should show
Import with same filename and beyond max size: max size error should show

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit and/or integration tests to cover this change or tests are not applicable
  • I have commented my code, particularly in hard-to-understand areas
  • I have either updated the source of truth or arranged for update with product owner if needed https://breedinginsight.atlassian.net/wiki/spaces/BI/pages/1559953409/Source+of+Truth

@HMS17
HMS17 marked this pull request as ready for review September 30, 2026 15:30
@HMS17
HMS17 requested review from a team and nickpalladino and removed request for a team September 30, 2026 15:30
HMS17 and others added 2 commits October 6, 2026 10:03
Co-authored-by: Nick <53413353+nickpalladino@users.noreply.github.com>
@HMS17
HMS17 requested a review from nickpalladino October 6, 2026 16:12
@nickpalladino
nickpalladino merged commit 7f685dc into develop Oct 6, 2026
1 of 2 checks passed
@nickpalladino
nickpalladino deleted the feature/BI-3032 branch October 6, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants