Repository navigation
[BI-3032] - Prevent .vcf file name duplication - #562
Merged
Merged
Conversation
HMS17
force-pushed
the
feature/BI-3032
branch
from
September 29, 2026 15:56
d1d5fc7 to
118ffdb
Compare
HMS17
marked this pull request as ready for review
September 30, 2026 15:30
HMS17
requested review from
a team and
nickpalladino
and removed request for
a team
September 30, 2026 15:30
nickpalladino
requested changes
Oct 2, 2026
Co-authored-by: Nick <53413353+nickpalladino@users.noreply.github.com>
nickpalladino
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-3032 - Prevent .vcf file name duplication
Updated GigwaGenotypeServiceImpl.java:submitGenotypeData to retrieve existing genotype imports and check if the vcf file name matches that of a vcf file already imported and if so, prevent import with an error message.
Dependencies
bi-web: develop
Testing
Try to import a vcf file with the same filename as another vcf already imported, check that import is prevented and error message appears
Other good cases to test:
Valid import with different filename: should import
Import with same filename and incorrect header: filename error should show
Import with same filename and beyond max size: max size error should show
Checklist: