Skip to content

Remove rest of CRUD operations from BrAPIGermplasmDAO - #557

Merged
jloux-brapi merged 4 commits into
epic/BI-2862from
feature/BI-2906
Oct 6, 2026
Merged

jloux-brapi merged 4 commits into
epic/BI-2862from
feature/BI-2906

Conversation

@jloux-brapi

@jloux-brapi jloux-brapi commented Sep 14, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Story: BI-2906

Dependencies

feature/BI-2905 branch of bi-web, epic/BI-2862 of the java prod server

Testing

Test importing and exporting Germplasm records

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit and/or integration tests to cover this change or tests are not applicable
  • I have commented my code, particularly in hard-to-understand areas
  • I have either updated the source of truth or arranged for update with product owner if needed https://breedinginsight.atlassian.net/wiki/spaces/BI/pages/1559953409/Source+of+Truth

@jloux-brapi
jloux-brapi requested a review from humsika September 14, 2026 22:55
Comment thread src/main/java/org/breedinginsight/brapi/v2/dao/BrAPIGermplasmDAO.java Outdated
@jloux-brapi
jloux-brapi requested a review from humsika September 17, 2026 12:48

@humsika humsika left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me and validated changes through UI, everything is working as expected.

@humsika humsika added the on hold Review, but do not merge until removed label Sep 17, 2026
Base automatically changed from feature/BI-2904 to epic/BI-2862 October 6, 2026 20:07
@jloux-brapi
jloux-brapi merged commit a426b22 into epic/BI-2862 Oct 6, 2026
0 of 2 checks passed
@jloux-brapi
jloux-brapi deleted the feature/BI-2906 branch October 6, 2026 20:09
@jloux-brapi jloux-brapi removed the on hold Review, but do not merge until removed label Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants