Repository navigation
Remove remote BLAST support and improved local BLAST - #8
Merged
Merged
Conversation
Collaborator
Author
|
Documentation build currently fails because docs/api/blast.rst still references the removed RemoteBlastSearcher. The docs directory was inspected but intentionally not modified. |
| "evalue": best_hsp.expect, | ||
| "identity": best_hsp.identities / best_hsp.align_length, | ||
| "query_coverage": best_hsp.align_length / query_length, | ||
| "query_coverage": ( |
Collaborator
There was a problem hiding this comment.
This changes “query coverage” from alignment-column length to the query-coordinate span of the best HSP. That seems reasonable and avoids gap-driven values above 100%, but it is slightly different from counting the exact query residues aligned.
I’m happy to accept this behavior for now. Could we add or track a follow-up test with gapped HSPs (and possibly multiple HSPs) to document the intended semantics?
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed remote/online BLAST implementation from the refactor-v2 codebase while preserving the local BLAST workflow. Updated BLAST support in the refactor-v2 codebase by removing remote BLAST functionality and improving the local BLAST workflow.
Changes
Removed
RemoteBlastSearcherfromsrc/lverage/blast.pyRemoved remote-only BLAST dependencies and constants:
requestsNCBI_EFETCH_URLSeqIODeleted
tests/v2/test_remote_blast.pyPreserved
LocalBlastSearcherPreserved shared BLAST parsing and ortholog-record logic
Confirmed no changes were required in:
src/lverage/pipeline.pysrc/lverage/ortholog_searcher.pyDocumentation
docs/api/blast.rststill contains references to remote BLAST andRemoteBlastSearcher.Remote BLAST changes
RemoteBlastSearchertests/v2/test_remote_blast.pyLocal BLAST changes
blastpinvocation to explicitly read the protein query from stdin using-query -Testing
Focused local BLAST tests:
12 passedThe local BLAST tests cover:
blastpcommand constructionblastdbcmd