Skip to content

Ignore q-values when matching Accept-Encoding - #882

Closed
Hexay wants to merge 1 commit into
BlueMap-Minecraft:masterfrom
Hexay:fix/accept-encoding-qvalues
Closed

Hexay wants to merge 1 commit into
BlueMap-Minecraft:masterfrom
Hexay:fix/accept-encoding-qvalues

Conversation

@Hexay

@Hexay Hexay commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Accept-Encoding: gzip;q=1.0 didn't match gzip

@TBlueF

TBlueF commented Oct 7, 2026

Copy link
Copy Markdown
Member

I agree that the Accept-Encoding header is not handled 100% correct currently, it doesn't support the ;q=x quality appendix and also doesn't support * .. however i am not sure if the HttpHeader class like this is the correct way to handle this, i'll take a look on how this should be fixed in a bit 👍

@TBlueF TBlueF closed this in 793f346 Oct 8, 2026
@TBlueF

TBlueF commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

I implemented it slightly differently, but i am not fully happy still. I guess at some point i will need to revisit how headers are parsed entirely :D

Edit: The reason i didn't want to have it in HttpHeader is because the quality-parameter syntax is technically not universally valid for every type of header, so parsing it there seemed not clean to me..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants