Repository navigation
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
|
|
The @bitgo/sdk-coin-starknet test failure is a CI-wide issue affecting all BitGoJS PRs since Oct 30 ~03:00 UTC. The test calls https://api.cartridge.gg/x/starknet/sepolia ▏(test/unit/walletInitializationBuilder.ts:134) which now returns HTTP 410 Gone ("starknet sepolia is discontinued and no longer served"). This needs a fix from the starknet team — the RPC URL must be updated to a live Sepolia endpoint. |
51df9c7 to
f14f6df
Compare
postApprove() unconditionally ran the TSS recreate-and-sign flow for TRANSACTION_REQUEST_FULL approvals, which reads transactions[0].unsignedTx. Message-only txRequests have an empty transactions array, so this crashed. postApprove() now returns early when the approval's intent is a message-sign intent (signMessage / signTypedStructuredData), leaving the message to be signed separately via signAndSendMessageTxRequest. Also hardens the signTxRequest assertions in all TSS signer variants (ecdsa, ecdsaMPCv2, eddsa, eddsaMPCv2) to check length > 0 instead of truthiness (an empty array is truthy), and types the transactionRequestFull info field on PendingApprovalInfo. Refs: DEFI-1257 TICKET: DEFI-1257
postApprove() unconditionally ran the TSS recreate-and-sign flow for TRANSACTION_REQUEST_FULL approvals, which reads transactions[0].unsignedTx. Message-only txRequests have an empty transactions array, so this crashed. postApprove() now returns early when the approval's intent is a message-sign intent (signMessage / signTypedStructuredData), leaving the message to be signed separately via signAndSendMessageTxRequest.
Also hardens the ecdsa signTxRequest assertions to check length > 0 instead of truthiness (an empty array is truthy), and types the transactionRequestFull info field on PendingApprovalInfo.
TICKET: DEFI-1257