Skip to content

add import option for trip data to fixbikenet.py - #107

Open
Manuel-Knepper wants to merge 4 commits into
mainfrom
feature/add_trips_to_network
Open

Manuel-Knepper wants to merge 4 commits into
mainfrom
feature/add_trips_to_network

Conversation

@Manuel-Knepper

Copy link
Copy Markdown
Member

Description

adds trip data to import files and implements add_trip_data_to_net function

Related issue

#83

Fixes #(issue number)
#83

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 📝 Documentation update
  • 🧹 Code refactor (no functional changes)
  • ✅ Test update

How has this been tested?

  • Unit tests
  • Integration tests
  • Manual testing

Test configuration:

  • OS: macOS

Screenshots (if applicable)

Checklist

  • I have read the contributing guidelines and have run the repository's pre-commit hooks and tests locally.
  • If this is an enhancement, I had it discussed first in a feature request issue.

Additional notes (optional)

@Manuel-Knepper
Manuel-Knepper marked this pull request as draft November 11, 2026 08:37
@codecov

codecov Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 26.82927% with 30 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
fixbikenet/utils.py 11.11% 24 Missing ⚠️
fixbikenet/fixbikenet.py 25.00% 5 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@Manuel-Knepper
Manuel-Knepper marked this pull request as ready for review November 11, 2026 08:38

@mszell mszell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were too many things not working with this. I tried to fix but it is too much that needs to be fixed, and I ran out of time.
At the same time I discovered also a critical bug from before that needed fixing first.
I take over this feature and will continue with this at another time. For now it does not work.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants